A0-4251: Avoid resumbissions on Aleph via better handling loop #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostekIV
reviewed
Apr 26, 2024
e2e-tests/Cargo.toml
Outdated
| @@ -4,7 +4,7 @@ version = "0.1.0" | |||
| edition = "2021" | |||
|
|
|||
| [dependencies] | |||
| aleph_client = { git = "https://github.com/Cardinal-Cryptography/aleph-node/", rev = "d52ede9" } | |||
| aleph_client = { git = "https://github.com/Cardinal-Cryptography/aleph-node/", rev = "c3c6d8b37d586b6b050d1e40675dd6b4ab6adcdb" } | |||
There was a problem hiding this comment.
just a heads up. You probably want to cherry-pick changes to aleph-client into release-13. Othwewise relayer build upon this pr wont be working before the next testnet release.
There was a problem hiding this comment.
Will update once Cardinal-Cryptography/aleph-node#1704 is merged
kostekIV
reviewed
Apr 26, 2024
relayer/Cargo.toml
Outdated
| @@ -3,7 +3,7 @@ members = ["relayer", "signer_client", "signer", "signer_tester"] | |||
| resolver = "2" | |||
|
|
|||
| [workspace.dependencies] | |||
| aleph_client = { git = "https://github.com/Cardinal-Cryptography/aleph-node", rev = "r-13.2" } | |||
| aleph_client = { git = "https://github.com/Cardinal-Cryptography/aleph-node", rev = "c3c6d8b37d586b6b050d1e40675dd6b4ab6adcdb" } | |||
There was a problem hiding this comment.
and I meant the comment to be here actually
ggawryal
commented
Apr 26, 2024
fbielejec
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved loop in ETH handler based on Azero handler. For this, I have introduced some changes in aleph-client: Cardinal-Cryptography/aleph-node#1679.